Use nodejs version 18 instead of version 14 in when building test docker image #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why: nodejs version 14 gives a deprecation warning when building the docker image from test dockerfile. Version 18 is the oldest nodejs version that is not deprecated.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2951 +/- ##
=======================================
Coverage 56.35% 56.35%
=======================================
Files 603 603
Lines 43849 43849
Branches 48 48
=======================================
Hits 24713 24713
Misses 19124 19124
Partials 12 12 ☔ View full report in Codecov by Sentry. |
lunkwill42
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why: nodejs version 14 gives a deprecation warning when building the test docker image. Version 18 is the oldest nodejs version that is not deprecated.